TODO (857B)
1 # Outstanding Design Decisions 2 3 ## TLV Unknown-Even Rule Enforcement 4 5 Per BOLT spec, unknown TLV types with even type numbers must cause message 6 rejection. Currently `decodeTlvStreamRaw` (from ppad-bolt1) does not enforce 7 this rule. 8 9 Options: 10 1. Enforce in ppad-bolt1's TLV decoder 11 2. Add a validation layer in ppad-bolt2 that wraps decoded messages 12 3. Leave to application layer 13 14 Recommendation: Enforce in ppad-bolt1 since it's a fundamental TLV rule. 15 16 ## Flake Dependency Path 17 18 flake.nix currently uses a local filesystem path for ppad-bolt1: 19 20 ```nix 21 ppad-bolt1 = { 22 type = "path"; 23 path = "/Users/jtobin/src/ppad/bolt1"; 24 ... 25 }; 26 ``` 27 28 This was a workaround for network connectivity issues. Should be reverted 29 to git URL when appropriate: 30 31 ```nix 32 ppad-bolt1 = { 33 type = "git"; 34 url = "git://git.ppad.tech/bolt1.git"; 35 ref = "master"; 36 ... 37 }; 38 ```