bolt4

Onion routing protocol, per BOLT #4 (docs.ppad.tech/bolt4).
git clone git://git.ppad.tech/bolt4.git
Log | Files | Refs | README | LICENSE

REVIEW-6f3327f.md (768B)

      1 # Review: IMPL1 Cryptographic Primitives (6f3327f)
      2 
      3 ## Status: Approved with minor suggestions
      4 
      5 ## Issues
      6 
      7 ### 1. Manual modular arithmetic in blindSecKey
      8 
      9 `Prim.hs:161-176`
     10 
     11 `blindSecKey` manually converts to Integer, multiplies, reduces mod q,
     12 and converts back. This works but is verbose and potentially slower than
     13 using secp256k1's native operations.
     14 
     15 **Suggestion:** Check if `ppad-secp256k1` exposes `mul_secret` or similar
     16 for scalar multiplication mod curve order. If so, use it.
     17 
     18 **Priority:** Low (correctness is fine, micro-optimization)
     19 
     20 ### 2. Duplicate helper could be consolidated
     21 
     22 `constantTimeEq` is defined here but also duplicated in Error.hs.
     23 Consider exporting from Prim to avoid duplication.
     24 
     25 **Priority:** Low (cosmetic)
     26 
     27 ## No blocking issues