bolt8

Encrypted and authenticated transport, per BOLT #8 (docs.ppad.tech/bolt8).
git clone git://git.ppad.tech/bolt8.git
Log | Files | Refs | README | LICENSE

REVIEW-c3040f683.md (431B)


      1 # Review c3040f683
      2 
      3 ## Findings
      4 - Low: Doc mismatch between encrypt and decrypt about key-rotation cadence.
      5   encrypt says "every 500 messages" while decrypt/decrypt_frame say 1000.
      6   This is misleading for callers reading Haddocks. See
      7   lib/Lightning/Protocol/BOLT8.hs:503.
      8 
      9 ## Notes
     10 - If you want a recoverable/partial state ("need more bytes") rather than
     11   InvalidLength, that needs an API/ADT change; see ARCH/IMPL proposal.