REVIEW-ebf75f4de8031a369868aba3a94ef89b6a25422b.md (462B)
1 # Review ebf75f4de8031a369868aba3a94ef89b6a25422b 2 3 ## Findings 4 - Low: test helper `flip_byte` uses `BS.index` without bounds checking, 5 so a bad index will crash the test rather than fail an assertion. 6 It is safe with the current constants (msg2 len 50, msg3 len 66), but 7 brittle if framing changes. See test/Main.hs:443. 8 9 ## Notes 10 - Doc fixes for key-rotation now align with nonce=1000. 11 - Negative tests look correct and target the intended failure modes.