bolt2

commit 89cbe52f87f20fc80e591643a8017c8bffd451c8
parent 1b79d069c1801ee0f7456152fd855758c3446161
Author: Jared Tobin <jared@jtobin.io>
Date:   Mon, 20 Apr 2026 15:44:51 +0800

test: add property tests for newtype validation

Add four property tests:

- HtlcId wrap/unwrap roundtrip
- SerialId wrap/unwrap roundtrip
- OnionPacket validates length (1366 only)
- TxId validates length (32 only)

Diffstat:
M
test/Main.hs
 | 
30
++++++++++++++++++++++++++++++

1 file changed, 30 insertions(+), 0 deletions(-)
diff --git a/test/Main.hs b/test/Main.hs
@@ -820,6 +820,10 @@ property_tests = testGroup "Properties" [
   , testProperty "RevokeAndAck roundtrip" propRevokeAndAckRoundtrip
   , testProperty "UpdateFee roundtrip" propUpdateFeeRoundtrip
   , testProperty "ChannelReestablish roundtrip" propChannelReestablishRoundtrip
+  , testProperty "HtlcId wrap/unwrap" propHtlcIdRoundtrip
+  , testProperty "SerialId wrap/unwrap" propSerialIdRoundtrip
+  , testProperty "OnionPacket validates length" propOnionPacketLength
+  , testProperty "TxId validates length" propTxIdLength
   ]
 
 -- Property: OpenChannel roundtrip
@@ -1294,6 +1298,32 @@ propChannelReestablishRoundtrip nextCommit nextRevoke = property $ do
     Right (decoded, _) -> decoded == msg
     Left _ -> False
 
+-- Property: HtlcId wrap/unwrap
+propHtlcIdRoundtrip :: Word64 -> Property
+propHtlcIdRoundtrip w = property $ unHtlcId (htlcId w) == w
+
+-- Property: SerialId wrap/unwrap
+propSerialIdRoundtrip :: Word64 -> Property
+propSerialIdRoundtrip w = property $ unSerialId (serialId w) == w
+
+-- Property: OnionPacket validates length (1366 only)
+propOnionPacketLength :: NonNegative Int -> Property
+propOnionPacketLength (NonNegative n) = property $
+  let len = n `mod` 2000
+      bs = BS.replicate len 0x00
+  in case onionPacket bs of
+    Just _  -> len == onionPacketLen
+    Nothing -> len /= onionPacketLen
+
+-- Property: TxId validates length (32 only)
+propTxIdLength :: NonNegative Int -> Property
+propTxIdLength (NonNegative n) = property $
+  let len = n `mod` 100
+      bs = BS.replicate len 0x00
+  in case mkTxId bs of
+    Just _  -> len == 32
+    Nothing -> len /= 32
+
 -- Helpers ---------------------------------------------------------------------
 
 -- | Decode hex string. Returns Nothing on invalid hex.